the-uncreative-bunch/magic-mod-core
1
0 Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Add Stick/Stick Recipies #2

Merged
abird356 merged 5 commits from feature/stick-items into main 2025-05-03 16:50:37 +00:00
Conversation 2 Commits 5 Files Changed 158
+1161 -1
abird356 commented 2025-05-03 16:24:21 +00:00 (Migrated from github.com)
Copy link
Copy source

Creates new sticks for each type of wood and adds the corresponding recipes.
In addition, adds a file to rewrite base Minecraft tags to use magic mod items instead of base game items.

Creates new sticks for each type of wood and adds the corresponding recipes. In addition, adds a file to rewrite base Minecraft tags to use magic mod items instead of base game items.
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2025-05-03 16:32:26 +00:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Copy link
Copy source

Pull Request Overview

This PR adds new stick items for each wood type and their corresponding recipes while updating item groups and data generation.

  • Added stick item registration in ModItems.java
  • Updated ModItemGroups.java to include new stick items
  • Introduced StickTagRecipeProvider and a DataGenerator for recipe data generation

Reviewed Changes

Copilot reviewed 141 out of 157 changed files in this pull request and generated 1 comment.

File Description
src/main/java/com/uncreativebunch/magicmod/item/ModItems.java Adds new stick items registration
src/main/java/com/uncreativebunch/magicmod/item/ModItemGroups.java Updates the magic item group to include new sticks
src/main/java/com/uncreativebunch/magicmod/datagen/StickTagRecipeProvider.java Implements a recipe provider with stub logging for stick recipes
src/main/java/com/uncreativebunch/magicmod/datagen/DataGenerator.java Registers the new data generation provider pack
Files not reviewed (16)
  • package.json: Language not supported
  • src/main/resources/assets/magic_mod/items/acacia_stick.json: Language not supported
  • src/main/resources/assets/magic_mod/items/bamboo_stick.json: Language not supported
  • src/main/resources/assets/magic_mod/items/birch_stick.json: Language not supported
  • src/main/resources/assets/magic_mod/items/cherry_stick.json: Language not supported
  • src/main/resources/assets/magic_mod/items/crimson_stick.json: Language not supported
  • src/main/resources/assets/magic_mod/items/dark_oak_stick.json: Language not supported
  • src/main/resources/assets/magic_mod/items/jungle_stick.json: Language not supported
  • src/main/resources/assets/magic_mod/items/mangrove_stick.json: Language not supported
  • src/main/resources/assets/magic_mod/items/oak_stick.json: Language not supported
  • src/main/resources/assets/magic_mod/items/pale_oak_stick.json: Language not supported
  • src/main/resources/assets/magic_mod/items/spruce_stick.json: Language not supported
  • src/main/resources/assets/magic_mod/items/warped_stick.json: Language not supported
  • src/main/resources/assets/magic_mod/lang/en_us.json: Language not supported
  • src/main/resources/assets/magic_mod/models/item/acacia_stick.json: Language not supported
  • src/main/resources/assets/magic_mod/models/item/bamboo_stick.json: Language not supported
Comments suppressed due to low confidence (1)

src/main/java/com/uncreativebunch/magicmod/datagen/StickTagRecipeProvider.java:22

  • [nitpick] The generate() method currently logs messages instead of actually generating recipes; please confirm whether this stub implementation is intentional or if actual recipe generation should be implemented.
MagicMod.LOGGER.info("Hello from the recipe provider!");
## Pull Request Overview This PR adds new stick items for each wood type and their corresponding recipes while updating item groups and data generation. - Added stick item registration in ModItems.java - Updated ModItemGroups.java to include new stick items - Introduced StickTagRecipeProvider and a DataGenerator for recipe data generation ### Reviewed Changes Copilot reviewed 141 out of 157 changed files in this pull request and generated 1 comment. | File | Description | | ---- | ----------- | | src/main/java/com/uncreativebunch/magicmod/item/ModItems.java | Adds new stick items registration | | src/main/java/com/uncreativebunch/magicmod/item/ModItemGroups.java | Updates the magic item group to include new sticks | | src/main/java/com/uncreativebunch/magicmod/datagen/StickTagRecipeProvider.java | Implements a recipe provider with stub logging for stick recipes | | src/main/java/com/uncreativebunch/magicmod/datagen/DataGenerator.java | Registers the new data generation provider pack | <details> <summary>Files not reviewed (16)</summary> * **package.json**: Language not supported * **src/main/resources/assets/magic_mod/items/acacia_stick.json**: Language not supported * **src/main/resources/assets/magic_mod/items/bamboo_stick.json**: Language not supported * **src/main/resources/assets/magic_mod/items/birch_stick.json**: Language not supported * **src/main/resources/assets/magic_mod/items/cherry_stick.json**: Language not supported * **src/main/resources/assets/magic_mod/items/crimson_stick.json**: Language not supported * **src/main/resources/assets/magic_mod/items/dark_oak_stick.json**: Language not supported * **src/main/resources/assets/magic_mod/items/jungle_stick.json**: Language not supported * **src/main/resources/assets/magic_mod/items/mangrove_stick.json**: Language not supported * **src/main/resources/assets/magic_mod/items/oak_stick.json**: Language not supported * **src/main/resources/assets/magic_mod/items/pale_oak_stick.json**: Language not supported * **src/main/resources/assets/magic_mod/items/spruce_stick.json**: Language not supported * **src/main/resources/assets/magic_mod/items/warped_stick.json**: Language not supported * **src/main/resources/assets/magic_mod/lang/en_us.json**: Language not supported * **src/main/resources/assets/magic_mod/models/item/acacia_stick.json**: Language not supported * **src/main/resources/assets/magic_mod/models/item/bamboo_stick.json**: Language not supported </details> <details> <summary>Comments suppressed due to low confidence (1)</summary> **src/main/java/com/uncreativebunch/magicmod/datagen/StickTagRecipeProvider.java:22** * [nitpick] The generate() method currently logs messages instead of actually generating recipes; please confirm whether this stub implementation is intentional or if actual recipe generation should be implemented. ``` MagicMod.LOGGER.info("Hello from the recipe provider!"); ``` </details>
BobdaFett (Migrated from github.com) approved these changes 2025-05-03 16:49:50 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
copilot-pull-request-reviewer[bot]
BobdaFett
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
alphafetus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: the-uncreative-bunch/magic-mod-core#2