Fully implement MultiEntry component #9

Closed
opened 2025-09-16 23:29:59 +00:00 by BobdaFett · 2 comments
BobdaFett commented 2025-09-16 23:29:59 +00:00 (Migrated from github.com)

As usual, this is the hardest component to design properly.

The application needs to collect information about these entry components, including the "member name" and the ValueType of the field. The information is stored within a HashMap<String, ValueType>, where the member_name is the String key and the ValueType is an enum containing type information.

The issue with the current implementation is that we don't have a way of easily accepting these inputs across the input components. The inputs do not accept the ValueType enum, and we would like to wrap them in an RwSignal if at all possible. This may require a full rework of the input components so that they properly verify that type of values passed in (i.e. we cannot pass an InputType::Number to a RadioList, since it only accepts InputType::String as a value type).

This should be discussed thoroughly before merging - this will be a significant change if it's pushed through.

As usual, this is the hardest component to design properly. The application needs to collect information about these entry components, including the "member name" and the `ValueType` of the field. The information is stored within a `HashMap<String, ValueType>`, where the `member_name` is the `String` key and the `ValueType` is an enum containing type information. The issue with the current implementation is that we don't have a way of easily accepting these inputs across the input components. The inputs do not accept the `ValueType` enum, and we would like to wrap them in an `RwSignal` if at all possible. This may require a full rework of the input components so that they properly verify that type of values passed in (i.e. we cannot pass an `InputType::Number` to a `RadioList`, since it only accepts `InputType::String` as a value type). This should be discussed thoroughly before merging - this will be a significant change if it's pushed through.
BobdaFett commented 2025-09-26 16:15:07 +00:00 (Migrated from github.com)

The components have been updated to use the correct data types, and so we can proceed to use this same data type for the multi entry component.

The components have been updated to use the correct data types, and so we can proceed to use this same data type for the multi entry component.
BobdaFett commented 2025-11-20 16:05:07 +00:00 (Migrated from github.com)

This was solved in #13. Closing this issue.

This was solved in #13. Closing this issue.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: r15-software-dev/scholarships-rs#9