feat: optimize imports to remove warnings

src/pages/api/comparisons.rs

@@ -8,12 +8,12 @@ use crate::common::{
     ComparisonData, ComparisonType, MapListComparison, NumberComparison, NumberListComparison,
     TextComparison, TextListComparison, ValueType,
 };
-use leptos::leptos_dom::log;
 use leptos::prelude::ServerFnError;
 use leptos::server;
 
 /// Helper function to create all sports comparisons. Only used to create initial
 /// comparison data, and should be removed upon completion of a comparison editor page.
+#[allow(unused)]
 fn create_sports_comparisons() -> Vec<ComparisonData> {
     vec![
         ComparisonData::new(
@@ -184,12 +184,8 @@ fn create_sports_comparisons() -> Vec<ComparisonData> {
     ]
 }
 
-#[server(CreateTestComparisons, endpoint = "/comparisons/create-test")]
-pub async fn create_test_comparisons() -> Result<(), ServerFnError> {
-    let client = create_dynamo_client().await;
-
-    log!("Creating test comparisons");
-
+#[allow(unused)]
+fn make_comp_list() -> Vec<ComparisonData> {
     let test_comp = ComparisonData::new(
         "math_sat_comp",
         "math_sat",
@@ -304,6 +300,19 @@ pub async fn create_test_comparisons() -> Result<(), ServerFnError> {
     comp_list.append(&mut sports_comps);
     comp_list.append(&mut major_comps);
 
+    comp_list
+}
+
+#[server(CreateTestComparisons, endpoint = "/comparisons/create-test")]
+pub async fn create_test_comparisons() -> Result<(), ServerFnError> {
+    use leptos::logging::log;
+
+    let client = create_dynamo_client().await;
+
+    log!("Creating test comparisons");
+
+    let comp_list = make_comp_list();
+
     for comparison in comp_list {
         if let Err(err) = client
             .put_item()
@@ -322,6 +331,8 @@ pub async fn create_test_comparisons() -> Result<(), ServerFnError> {
 
 #[server]
 pub async fn get_comparison_info() -> Result<Vec<ComparisonData>, ServerFnError> {
+    use leptos::logging::log;
+
     let client = create_dynamo_client().await;
 
     log!("Getting all comparisons from the database");

src/pages/api/scholarships.rs

@@ -3,15 +3,19 @@ use aws_sdk_dynamodb::{
     types::AttributeValue,
     error::ProvideErrorMetadata,
 };
-
+#[cfg(feature = "ssr")]
 use leptos::leptos_dom::log;
-use leptos::prelude::ServerFnError;
-use leptos::server;
+#[cfg(feature = "ssr")]
 use uuid::Uuid;
-use crate::common::{ExpandableInfo, ValueType};
-
 #[cfg(feature = "ssr")]
 use crate::pages::utils::server_utils::create_dynamo_client;
+#[cfg(feature = "ssr")]
+use crate::common::ValueType;
+
+use crate::common::ExpandableInfo;
+
+use leptos::prelude::ServerFnError;
+use leptos::server;
 
 #[server(GetScholarshipInfo, endpoint = "/scholarship/info/get")]
 pub async fn get_scholarship_info(id: String) -> Result<ExpandableInfo, ServerFnError> {

src/pages/home_page.rs

@@ -217,7 +217,7 @@ pub fn HomePage() -> impl IntoView {
                     {move || {
                         server_resource
                             .get()
-                            .map(|submission| {
+                            .map(|_| {
                                 view! {
                                     <Row>
                                         <div class="flex flex-col flex-1" />

src/pages/loaner_page.rs

@@ -4,7 +4,10 @@ use aws_sdk_dynamodb::{Client, error::ProvideErrorMetadata, types::AttributeValu
 #[cfg(feature = "ssr")]
 use serde_dynamo::{from_item, to_item};
 
-use crate::common::{ExpandableInfo, ValueType};
+#[cfg(feature = "ssr")]
+use crate::common::ValueType;
+
+use crate::common::ExpandableInfo;
 use crate::components::{ActionButton, Banner, DashboardButton, OutlinedTextField, Panel, Row, Select, TextFieldType, ValidatedForm};
 use chrono::{FixedOffset, TimeZone};
 use leptos::Params;
@@ -16,7 +19,6 @@ use leptos_router::hooks::{use_navigate, use_params};
 use leptos_router::params::Params;
 use serde::{Deserialize, Serialize};
 use std::collections::HashMap;
-use traits::{AsReactive, ReactiveCapture};
 
 #[derive(Params, PartialEq)]
 struct LoanerParams {
@@ -243,7 +245,6 @@ pub fn LoanerPage() -> impl IntoView {
 pub fn LoanerBorrowForm() -> impl IntoView {
     // Register server actions.
     let create_entry_action = ServerAction::<CreateBorrowEntry>::new();
-    let navigate = use_navigate();
 
     let data = RwSignal::new(HashMap::new());
     let elements_disabled = Signal::derive(move || create_entry_action.pending().get());

src/pages/scholarship_info.rs

@@ -10,7 +10,7 @@ use crate::components::{ActionButton, Banner, ChipsList, Loading, OutlinedTextFi
 use super::UnauthenticatedPage;
 use crate::common::ComparisonData;
 use crate::pages::utils::get_user_claims;
-use super::api::{get_comparison_info, get_provider_scholarships, get_scholarship_info, CreateScholarshipInfo, CreateTestComparisons, RegisterScholarship, DeleteProviderScholarship};
+use super::api::{get_comparison_info, get_provider_scholarships, get_scholarship_info, CreateScholarshipInfo, RegisterScholarship, DeleteProviderScholarship};
 
 
 /// # Scholarship Info Page
@@ -31,7 +31,7 @@ pub fn ScholarshipInfoPage() -> impl IntoView {
             .and_then(|params| params.id.clone())
     });
     
-    let create_test_comps = ServerAction::<CreateTestComparisons>::new();
+    // let create_test_comps = ServerAction::<CreateTestComparisons>::new();
     
     let on_delete = move || {
         let navigate = use_navigate();
@@ -279,7 +279,7 @@ fn ScholarshipListEntry(
 ) -> impl IntoView {
     let navigate = use_navigate();
     let user_claims = get_user_claims();
-    let user_id = Memo::new(move |_| {
+    let _user_id = Memo::new(move |_| {
         user_claims.get()
             .map(|info| info.claims.subject.clone())
     });
@@ -350,13 +350,6 @@ fn ScholarshipForm(
     /// submission fails, this function is not run.
     #[prop(into)] on_submit: Callback<()>
 ) -> impl IntoView {
-    let submit_status = RwSignal::new(SubmitStatus::Idle);
-    let elements_disabled = Signal::derive(move || {
-        match submit_status.get() {
-            SubmitStatus::Sending => true,
-            _ => false
-        }
-    });
     // let result_msg = Signal::derive(move || {
     //     match submit_status.get() {
     //         SubmitStatus::Idle => "".into(),
@@ -367,7 +360,12 @@ fn ScholarshipForm(
     // });
 
     let submit_action = ServerAction::<CreateScholarshipInfo>::new();
-    
+
+    let submit_status = RwSignal::new(SubmitStatus::Idle);
+    let elements_disabled = Signal::derive(move || {
+        matches!(submit_action.pending().get(), true)
+    });
+
     Effect::new(move || {
         if submit_action.pending().get() {
             submit_status.set(SubmitStatus::Sending);
@@ -380,7 +378,7 @@ fn ScholarshipForm(
                     submit_status.set(SubmitStatus::Success);
                     on_submit.run(());
                 },
-                Err(err) => submit_status.set(SubmitStatus::Error(err.to_string()))
+                Err(_err) => submit_status.set(SubmitStatus::Error(()))
             }
         }
     });
@@ -455,7 +453,7 @@ fn ScholarshipForm(
                             scholarship_info.get()
                                 .map(|res_scholarship| {
                                     match res_scholarship {
-                                        Ok(scholarship) => {
+                                        Ok(_) => {
                                             Either::Left(view! {
                                                 <Row>
                                                     <h1 class="text-3xl font-bold">